gtk4.git
6 years agocssprovider: Fix compilation wth VERIFY_TREE set
Timm Bäder [Wed, 21 Aug 2019 09:19:35 +0000 (11:19 +0200)]
cssprovider: Fix compilation wth VERIFY_TREE set

6 years agocssmatcher: Inline node values into matcher
Timm Bäder [Wed, 21 Aug 2019 09:18:22 +0000 (11:18 +0200)]
cssmatcher: Inline node values into matcher

So we don't have to go through the matcher->node->decl every time

6 years agocssanimatedstyle: Make set_animated_value transfer-full
Timm Bäder [Mon, 19 Aug 2019 09:06:04 +0000 (11:06 +0200)]
cssanimatedstyle: Make set_animated_value transfer-full

6 years agocssimage: Use gtk_internal_return_val_*
Timm Bäder [Mon, 19 Aug 2019 08:56:19 +0000 (10:56 +0200)]
cssimage: Use gtk_internal_return_val_*

GtkCssImage is not public and being used in hot paths, e.g. CSS.

6 years agogtkprivate: Only define gtk_internal_return_if* for consistency checks
Timm Bäder [Mon, 19 Aug 2019 08:54:09 +0000 (10:54 +0200)]
gtkprivate: Only define gtk_internal_return_if* for consistency checks

The wanted behavior here is that these are only defined if the buildtype
is debug, i.e. full debugging.

6 years agocssanimatedstyle: Save animation in array
Timm Bäder [Mon, 19 Aug 2019 07:42:51 +0000 (09:42 +0200)]
cssanimatedstyle: Save animation in array

6 years agocssanimatedstyle: Avoid type check in loop
Timm Bäder [Mon, 19 Aug 2019 06:46:27 +0000 (08:46 +0200)]
cssanimatedstyle: Avoid type check in loop

We can just do the check once as source is not going to change within
the loop.

6 years agocssanimatedstyle: Avoid unnecessary transition work
Timm Bäder [Mon, 19 Aug 2019 06:45:07 +0000 (08:45 +0200)]
cssanimatedstyle: Avoid unnecessary transition work

No need to do all the transition work if the transition duration will be
0 for all of them.

6 years agocssrgbavalue: Add & use new_white()
Timm Bäder [Fri, 23 Aug 2019 06:14:54 +0000 (08:14 +0200)]
cssrgbavalue: Add & use new_white()

6 years agocssrgbavalue: Add an opaque white singleton
Timm Bäder [Fri, 23 Aug 2019 06:13:20 +0000 (08:13 +0200)]
cssrgbavalue: Add an opaque white singleton

Used a few hundred times in the widget-factory.

6 years agocssrgbavalue: Add a singleton for transparent colors
Timm Bäder [Sat, 17 Aug 2019 17:53:32 +0000 (19:53 +0200)]
cssrgbavalue: Add a singleton for transparent colors

The most common background color is no background color.

6 years agocssdimensionvalue: Create a few more common singletons
Timm Bäder [Sat, 17 Aug 2019 17:29:44 +0000 (19:29 +0200)]
cssdimensionvalue: Create a few more common singletons

6 years agocssstaticstyle: Make set_value (transfer-full)
Timm Bäder [Sat, 17 Aug 2019 17:08:16 +0000 (19:08 +0200)]
cssstaticstyle: Make set_value (transfer-full)

We only call this in one place and we can avoid a ref + unref pair this
way.

6 years agocss: Avoid more type checks in hot paths
Timm Bäder [Sat, 17 Aug 2019 16:55:35 +0000 (18:55 +0200)]
css: Avoid more type checks in hot paths

6 years agocsspalettevalue: Use simple arrays instead of a hashtable
Timm Bäder [Sat, 17 Aug 2019 16:23:36 +0000 (18:23 +0200)]
csspalettevalue: Use simple arrays instead of a hashtable

Use two sorted name/value arrays to save the colors instead of a
hashtable. This makes palette values faster to compare etc.

6 years agocssanimatedstyle: Remove some casts in hot paths
Timm Bäder [Sat, 17 Aug 2019 14:12:57 +0000 (16:12 +0200)]
cssanimatedstyle: Remove some casts in hot paths

gtk_css_animated_style_create_css_transitions down from 16% to 11%
when repeatedly clicking on a spinbutton button in the widget factory.

6 years agobitmask: Add _gtk_allocated_bitmask_to_string
Timm Bäder [Thu, 22 Aug 2019 15:16:21 +0000 (17:16 +0200)]
bitmask: Add _gtk_allocated_bitmask_to_string

6 years agoAdwaita: Hack around list button styling
Timm Bäder [Fri, 23 Aug 2019 07:40:29 +0000 (09:40 +0200)]
Adwaita: Hack around list button styling

Once again.

6 years agowidget-factory: Add a spinbutton in a list
Timm Bäder [Fri, 23 Aug 2019 07:40:02 +0000 (09:40 +0200)]
widget-factory: Add a spinbutton in a list

6 years agospinbutton: Use a box layout
Timm Bäder [Fri, 23 Aug 2019 07:32:00 +0000 (09:32 +0200)]
spinbutton: Use a box layout

6 years agomenubutton: Add a create_popup_func
Timm Bäder [Thu, 22 Aug 2019 07:06:43 +0000 (09:06 +0200)]
menubutton: Add a create_popup_func

Some use cases require a menu button to create the popup on demand.

6 years agomenubutton: Remove unused member
Timm Bäder [Thu, 22 Aug 2019 06:04:24 +0000 (08:04 +0200)]
menubutton: Remove unused member

6 years agolabel: Remove "line" from wrap properties
Timm Bäder [Thu, 22 Aug 2019 10:41:39 +0000 (12:41 +0200)]
label: Remove "line" from wrap properties

The property names are "wrap" and "wrap-mode", so it doesn't make sense
that the accessors refer to line_wrap and line_wrap_mode.

6 years agogsktransform: Fix documentation comment
Timm Bäder [Wed, 21 Aug 2019 08:56:20 +0000 (10:56 +0200)]
gsktransform: Fix documentation comment

There is no @m.

6 years agosnapshot: Stop exporting _append_node_internal
Timm Bäder [Fri, 16 Aug 2019 05:17:41 +0000 (07:17 +0200)]
snapshot: Stop exporting _append_node_internal

Unused outside of gtksnapshot.c

6 years agoMerge branch 'wip/chergert/remove-emit-by-name' into 'master'
Timm Bäder [Sun, 8 Sep 2019 07:40:55 +0000 (07:40 +0000)]
Merge branch 'wip/chergert/remove-emit-by-name' into 'master'

texttag: avoid use of g_signal_emit_by_name()

See merge request GNOME/gtk!1088

6 years agoUpdate POTFILES.skip
Piotr Drąg [Sat, 7 Sep 2019 11:29:47 +0000 (13:29 +0200)]
Update POTFILES.skip

6 years agoUpdated Czech translation
Marek Černocký [Sat, 7 Sep 2019 10:10:12 +0000 (12:10 +0200)]
Updated Czech translation

6 years agoUpdate Turkish translation
Emin Tufan Çetin [Fri, 6 Sep 2019 18:50:05 +0000 (18:50 +0000)]
Update Turkish translation

6 years agotexttag: avoid use of g_signal_emit_by_name()
Christian Hergert [Thu, 5 Sep 2019 02:39:24 +0000 (19:39 -0700)]
texttag: avoid use of g_signal_emit_by_name()

This avoids looking up the signal by name and instead uses the saved
signal identifier from gtktexttagtable.c

6 years agoMerge branch 'wip/chergert/faster-comparison' into 'master'
Matthias Clasen [Wed, 4 Sep 2019 17:02:06 +0000 (17:02 +0000)]
Merge branch 'wip/chergert/faster-comparison' into 'master'

textlayout: remove use of GtkTextIter in line comparison

See merge request GNOME/gtk!1087

6 years agotextlayout: remove use of GtkTextIter in line comparison
Christian Hergert [Wed, 4 Sep 2019 16:12:54 +0000 (09:12 -0700)]
textlayout: remove use of GtkTextIter in line comparison

We do not need to create a GtkTextIter to perform the comparison here as
that will require a number of validation steps that are extra work
compared to just discovering the GtkTextLine number directly.

6 years agoMerge branch 'gtk-4-issue2128' into 'master'
Matthias Clasen [Tue, 3 Sep 2019 14:38:30 +0000 (14:38 +0000)]
Merge branch 'gtk-4-issue2128' into 'master'

[gtk4] wayland: Fix xdg-output v3 support

See merge request GNOME/gtk!1082

6 years agowayland: Fix xdg-output v3 support
Olivier Fourdan [Tue, 3 Sep 2019 13:59:18 +0000 (15:59 +0200)]
wayland: Fix xdg-output v3 support

The xdg_output.done event is deprecated in xdg-output v3, so clients
need to rely on the wl_output.done event instead.

However, applying the changes on the fist wl_output.event when using
xdg-output v3 may lead to an incomplete change, as following xdg-output
updates may follow.

Make sure we apply xdg-output events on wl_output.done events with
xdg-output v3.

https://gitlab.gnome.org/GNOME/gtk/issues/2128

6 years agoUpdate Catalan translation
Jordi Mas [Sun, 1 Sep 2019 06:28:18 +0000 (08:28 +0200)]
Update Catalan translation

6 years agoUpdate Japanese translation
Ryuta Fujii [Sat, 31 Aug 2019 13:45:30 +0000 (13:45 +0000)]
Update Japanese translation

6 years agoUpdate Japanese translation
Ryuta Fujii [Sat, 31 Aug 2019 12:31:35 +0000 (12:31 +0000)]
Update Japanese translation

6 years agoUpdate Japanese translation
Ryuta Fujii [Sat, 31 Aug 2019 12:27:01 +0000 (12:27 +0000)]
Update Japanese translation

6 years agoUpdate Korean translation
Changwoo Ryu [Fri, 30 Aug 2019 14:10:45 +0000 (14:10 +0000)]
Update Korean translation

6 years agoMerge branch 'typo' into 'master'
Timm Bäder [Thu, 29 Aug 2019 13:56:13 +0000 (13:56 +0000)]
Merge branch 'typo' into 'master'

popover: fix typo in schema string

See merge request GNOME/gtk!1071

6 years agoUpdate French translation
Alexandre Franke [Thu, 29 Aug 2019 12:53:34 +0000 (12:53 +0000)]
Update French translation

6 years agopopover: fix typo in schema string
Alexandre Franke [Thu, 29 Aug 2019 12:50:20 +0000 (14:50 +0200)]
popover: fix typo in schema string

6 years agoUpdated Danish translation of gtk-properties
Ask Hjorth Larsen [Thu, 29 Aug 2019 10:37:41 +0000 (12:37 +0200)]
Updated Danish translation of gtk-properties

6 years agoUpdated Danish translation of gtk
Ask Hjorth Larsen [Thu, 29 Aug 2019 10:37:41 +0000 (12:37 +0200)]
Updated Danish translation of gtk

6 years agoUpdate Catalan translation
Jordi Mas [Wed, 28 Aug 2019 17:37:59 +0000 (19:37 +0200)]
Update Catalan translation

6 years agoMerge branch 'wip/ricotz/issue2107' into 'master'
Benjamin Otte [Mon, 26 Aug 2019 17:00:34 +0000 (17:00 +0000)]
Merge branch 'wip/ricotz/issue2107' into 'master'

gsk: Add missing 'transfer full' annotations of instance parameters

Closes #2107

See merge request GNOME/gtk!1065

6 years agogsk: Add missing 'transfer full' annotations of instance parameters
Rico Tzschichholz [Mon, 26 Aug 2019 13:24:29 +0000 (15:24 +0200)]
gsk: Add missing 'transfer full' annotations of instance parameters

Fixes https://gitlab.gnome.org/GNOME/gtk/issues/2107

6 years agoMerge branch 'office-runner-crash' into 'master'
Matthias Clasen [Mon, 26 Aug 2019 13:50:43 +0000 (13:50 +0000)]
Merge branch 'office-runner-crash' into 'master'

Fix a crash in gtk-builder-tool

See merge request GNOME/gtk!1064

6 years agoFix a crash in gtk-builder-tool
Matthias Clasen [Mon, 26 Aug 2019 13:34:15 +0000 (15:34 +0200)]
Fix a crash in gtk-builder-tool

Crash pointed out by Bastien Nocera.

Testcase included.

6 years agoUpdate Korean translation
Changwoo Ryu [Mon, 26 Aug 2019 11:20:16 +0000 (11:20 +0000)]
Update Korean translation

6 years agoMerge branch 'doc-typos' into 'master'
Timm Bäder [Mon, 26 Aug 2019 09:18:47 +0000 (09:18 +0000)]
Merge branch 'doc-typos' into 'master'

Minor typos in the Documentation (a/an)

See merge request GNOME/gtk!1061

6 years agoMinor typos in the Documentation (a/an)
Дилян Палаузов [Sun, 25 Aug 2019 12:52:24 +0000 (12:52 +0000)]
Minor typos in the Documentation (a/an)

6 years agoMerge branch 'gdkmonitor-x11-manufacturer' into 'master'
Matthias Clasen [Sun, 25 Aug 2019 11:58:02 +0000 (11:58 +0000)]
Merge branch 'gdkmonitor-x11-manufacturer' into 'master'

gdk: x11: Fill GdkMonitor manufacturer with PNP id from EDID

Closes #1765

See merge request GNOME/gtk!859

6 years agoUpdate Hungarian translation
Balázs Úr [Sat, 24 Aug 2019 20:23:45 +0000 (20:23 +0000)]
Update Hungarian translation

6 years agoUpdate Swedish translation
Anders Jonsson [Thu, 22 Aug 2019 09:45:38 +0000 (09:45 +0000)]
Update Swedish translation

6 years agoMerge branch 'build-remove-xiproto-xreply-check-gtk4' into 'master'
Emmanuele Bassi [Wed, 21 Aug 2019 19:18:17 +0000 (19:18 +0000)]
Merge branch 'build-remove-xiproto-xreply-check-gtk4' into 'master'

Remove NEED_XIPROTO_H_FOR_XREPLY check

See merge request GNOME/gtk!1059

6 years agoRemove NEED_XIPROTO_H_FOR_XREPLY check
Christoph Reiter [Wed, 21 Aug 2019 18:46:30 +0000 (20:46 +0200)]
Remove NEED_XIPROTO_H_FOR_XREPLY check

It was only defined in the old autotools build to support a >20 year old x11,
https://bugzilla.gnome.org/show_bug.cgi?id=148032

6 years agoUpdated Spanish translation
Daniel Mustieles [Tue, 20 Aug 2019 10:45:23 +0000 (12:45 +0200)]
Updated Spanish translation

6 years agoUpdate Romanian translation
Daniel Șerbănescu [Mon, 19 Aug 2019 11:50:59 +0000 (11:50 +0000)]
Update Romanian translation

6 years agoUpdate Romanian translation
Daniel Șerbănescu [Mon, 19 Aug 2019 11:09:45 +0000 (11:09 +0000)]
Update Romanian translation

6 years agoUpdated Lithuanian translation
Aurimas Černius [Sun, 18 Aug 2019 18:41:16 +0000 (21:41 +0300)]
Updated Lithuanian translation

6 years agoUpdate Indonesian translation
Kukuh Syafaat [Fri, 16 Aug 2019 09:16:05 +0000 (09:16 +0000)]
Update Indonesian translation

6 years agoUpdate Basque translation
Asier Sarasua Garmendia [Fri, 16 Aug 2019 08:01:11 +0000 (08:01 +0000)]
Update Basque translation

6 years agoUpdate Basque translation
Asier Sarasua Garmendia [Fri, 16 Aug 2019 07:55:49 +0000 (07:55 +0000)]
Update Basque translation

6 years agoscale: Add a destroy notify to set_format_value_func
Timm Bäder [Thu, 15 Aug 2019 15:21:47 +0000 (17:21 +0200)]
scale: Add a destroy notify to set_format_value_func

Closes #2098

6 years agoscaler: Avoid some signal connections
Timm Bäder [Thu, 15 Aug 2019 15:12:30 +0000 (17:12 +0200)]
scaler: Avoid some signal connections

We're mainly using this for icons that will never change contents or
size, and we're using a GtkScaler per such icon when on a hidpi setup,
so just avoid the two signal connections per icon.

6 years agospinbutton: Use gtk_button_new_from_icon_name
Timm Bäder [Wed, 14 Aug 2019 09:33:56 +0000 (11:33 +0200)]
spinbutton: Use gtk_button_new_from_icon_name

6 years agowidget: Don't duplicate events to translate coordinates
Timm Bäder [Tue, 13 Aug 2019 10:29:00 +0000 (12:29 +0200)]
widget: Don't duplicate events to translate coordinates

6 years agowidget: Remove captured event handler code
Timm Bäder [Tue, 13 Aug 2019 10:10:43 +0000 (12:10 +0200)]
widget: Remove captured event handler code

6 years agoscrolledwindow: Stop using _gtk_widget_set_captured_event_handler
Timm Bäder [Tue, 13 Aug 2019 10:08:36 +0000 (12:08 +0200)]
scrolledwindow: Stop using _gtk_widget_set_captured_event_handler

We can use an event controller with phase = CAPTURE these days.

6 years agoUpdate Romanian translation
Daniel Șerbănescu [Wed, 14 Aug 2019 09:07:20 +0000 (09:07 +0000)]
Update Romanian translation

(cherry picked from commit 1e8d46352e3cf85e1f12edaf43e73134a6419f29)

6 years agoUpdate Romanian translation
Daniel Șerbănescu [Wed, 14 Aug 2019 06:30:03 +0000 (06:30 +0000)]
Update Romanian translation

(cherry picked from commit 10603f95985940a45d283104b123aa5be006a6ed)

6 years agoMerge branch '948-patch-renaming-a-file-can-make-it-to-loose-selection_GTK4' into...
Matthias Clasen [Tue, 13 Aug 2019 21:18:41 +0000 (21:18 +0000)]
Merge branch '948-patch-renaming-a-file-can-make-it-to-loose-selection_GTK4' into 'master'

filechooser: keep file selected after being renamed

Closes #948

See merge request GNOME/gtk!1053

6 years agotext view: Fix a typo
Matthias Clasen [Tue, 13 Aug 2019 19:16:03 +0000 (15:16 -0400)]
text view: Fix a typo

Pointed out in https://gitlab.gnome.org/GNOME/gtk/issues/2094

6 years agoUpdate Catalan translation
Jordi Mas [Tue, 13 Aug 2019 06:40:18 +0000 (08:40 +0200)]
Update Catalan translation

6 years agoUpdate Romanian translation
Daniel Șerbănescu [Tue, 13 Aug 2019 04:37:04 +0000 (04:37 +0000)]
Update Romanian translation

(cherry picked from commit f9acfa1bd846f1caa411ac06177108ca2ba1d6c3)

6 years agofilechooser: keep file selected after being renamed
Nelson Benítez León [Mon, 12 Aug 2019 21:32:56 +0000 (17:32 -0400)]
filechooser: keep file selected after being renamed

Because otherwise when the file list is sorted "by name"
and the new name causes the file to be re-sorted to another
row, the selection stays in the old row which is now
occupied by a different file.

Fixed by keeping track of the renamed file and revealing
it in the "row-changed" signal handler, which gets emitted
after a file is renamed.

Fixes issue #948

6 years agoUpdate Romanian translation
Daniel Șerbănescu [Mon, 12 Aug 2019 08:35:22 +0000 (08:35 +0000)]
Update Romanian translation

6 years agoUpdate Polish translation
Piotr Drąg [Sun, 11 Aug 2019 12:37:14 +0000 (14:37 +0200)]
Update Polish translation

6 years agoAdwaita: Style spinbutton up/down children explicitly
Timm Bäder [Sun, 11 Aug 2019 08:41:34 +0000 (10:41 +0200)]
Adwaita: Style spinbutton up/down children explicitly

Once again to increase the specificty above that of the
"list row button.etc." selector. Makes hovering spinbutton buttons in
lists look normal again.

6 years agoAdwaita: Update .devel headerbar styling
Timm Bäder [Sun, 11 Aug 2019 08:30:01 +0000 (10:30 +0200)]
Adwaita: Update .devel headerbar styling

Just pull in the changes from gtk-3-24

6 years agorange: Avoid a divison by 0
Timm Bäder [Sun, 11 Aug 2019 08:06:52 +0000 (10:06 +0200)]
range: Avoid a divison by 0

Based on a patch by Blake Latchford

Fixes #618

6 years agoAccelLabel: Add get_accel_closure() accessor
Daniel Boles [Mon, 7 Aug 2017 09:38:37 +0000 (10:38 +0100)]
AccelLabel: Add get_accel_closure() accessor

Fixes #875

6 years agocolor chooser: Port checkered pattern drawing from cairo
Timm Bäder [Sun, 11 Aug 2019 06:34:43 +0000 (08:34 +0200)]
color chooser: Port checkered pattern drawing from cairo

6 years agorange: Use public delay-factory API
Timm Bäder [Sat, 10 Aug 2019 18:08:59 +0000 (20:08 +0200)]
range: Use public delay-factory API

6 years agocellrenderer: Add accessors for {get,set}_is_expande{r,d}
Timm Bäder [Sun, 11 Aug 2019 06:53:10 +0000 (08:53 +0200)]
cellrenderer: Add accessors for {get,set}_is_expande{r,d}

6 years agotestsuite: Add another repeat node test case
Timm Bäder [Sat, 10 Aug 2019 17:56:10 +0000 (19:56 +0200)]
testsuite: Add another repeat node test case

6 years agoAdwaita: Fix hovering modelbutton arrows
Timm Bäder [Sat, 10 Aug 2019 17:50:17 +0000 (19:50 +0200)]
Adwaita: Fix hovering modelbutton arrows

This CSS snippet was supposed to only recolor the popover arrow but
ended up also recoloring the > arrow on modelbuttons that show a
submenu. Make the selector more specific.

6 years agoiconcache: ref textures
Timm Bäder [Sat, 10 Aug 2019 17:36:56 +0000 (19:36 +0200)]
iconcache: ref textures

We can't just assume that the pointer we'se using as a cache key will
stay unique forever. The texture might be freed, and a later allocated
texture might have the same addres now, causing the cache to return
incorrect results.

6 years agoiconcache: Replace broken debugging code
Timm Bäder [Sat, 10 Aug 2019 13:29:22 +0000 (15:29 +0200)]
iconcache: Replace broken debugging code

6 years agotestsuite: Add a repeat node test case
Timm Bäder [Sat, 10 Aug 2019 12:47:02 +0000 (14:47 +0200)]
testsuite: Add a repeat node test case

6 years agogl renderer: Implement a subset of repeat nodes
Timm Bäder [Sat, 10 Aug 2019 12:45:45 +0000 (14:45 +0200)]
gl renderer: Implement a subset of repeat nodes

6 years agotreeview: Redo tree line drawing using textures
Timm Bäder [Sat, 10 Aug 2019 07:14:13 +0000 (09:14 +0200)]
treeview: Redo tree line drawing using textures

Gets rid of the remaining cairo nodes used for line drawing.

6 years agotreeview: Redo grid line drawing using textures
Timm Bäder [Sat, 10 Aug 2019 06:49:45 +0000 (08:49 +0200)]
treeview: Redo grid line drawing using textures

The cairo pattern in use was simple enough, so just use a 2×1 or 1×2
texture to draw horizontal and vertical grid lines. This avoids a bunch
of cairo nodes (that can't be cached by the renderers).

6 years agosnapshot: Annotate child_bounds parameter of push_repeat as nullable
Timm Bäder [Sat, 10 Aug 2019 06:43:44 +0000 (08:43 +0200)]
snapshot: Annotate child_bounds parameter of push_repeat as nullable

6 years agotreeview: Shorten destroy() implementation
Timm Bäder [Sat, 10 Aug 2019 06:09:36 +0000 (08:09 +0200)]
treeview: Shorten destroy() implementation

6 years agotreeview: Remove two _dashes members
Timm Bäder [Fri, 9 Aug 2019 18:22:01 +0000 (20:22 +0200)]
treeview: Remove two _dashes members

Tree lines and grid lines always look the same these days.

6 years agotreeview: Remove GTK_TREE_VIEW_FOREGROUND_LINE
Timm Bäder [Fri, 9 Aug 2019 18:01:43 +0000 (20:01 +0200)]
treeview: Remove GTK_TREE_VIEW_FOREGROUND_LINE

6 years agospinbutton: Remove an unnecessary queue_draw() call
Timm Bäder [Fri, 9 Aug 2019 17:45:36 +0000 (19:45 +0200)]
spinbutton: Remove an unnecessary queue_draw() call

6 years agoscale: Properly update when inverted
Timm Bäder [Fri, 9 Aug 2019 17:36:01 +0000 (19:36 +0200)]
scale: Properly update when inverted

Just queue_resize()ing the range itself doesn't work as it will just
re-allocate all the child widgets (i.e. just the trough) to its old
position and size.